Add copy link button #1001
Closed
Add copy link button #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for taking a look at the project. I don't feel this is necessary since you can always right-click or long-press on mobile to copy a link to the clipboard. I'd prefer to leave it as-is unless there's some compelling reason to add the button. Of course though you're more than welcome to run your own instance of the app if you'd really like this customization! I think the CORS is pretty open for the manifest and I'm happy to make it more permissive if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for your work on this project! I’ve added a "copy to clipboard" button for each course video link to improve usability. Let me know if there’s anything you’d like me to adjust or improve in this PR.